Replace is-ci with ci-info.isCI
#189
Open
+55
−19
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TheDevMinerTV
changed the title
is-ci with ci-info.isCiis-ci with ci-info.isCI
sibiraj-s
reviewed
Nov 18, 2024
| }, | ||
| "dependencies": { | ||
| "camel-case": "^4.1.2", | ||
| "ci-info": "^4.1.0", |
Collaborator
There was a problem hiding this comment.
You removed a devDependency and introduced a new dependency 👀 . is-ci is just a devDependency. I don't see any harm in it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Additional details
is-ci just imports the underlying ci-info package and exports a single field. We might as well just use that package instead and save ourselves (/NPM) the extra lookup and bandwidth (4kB).
This PR saves about 3kB per install for developers, and two HTTP call to NPMs API. It doesn't impact dependants.